fix: prevent retry backlog starvation (#274)

This commit is contained in:
kikootwo
2026-08-18 15:07:10 -04:00
committed by GitHub
parent 7c7d7bc7dd
commit a013e2191f
7 changed files with 167 additions and 9 deletions
@@ -34,6 +34,7 @@ function futureDate(days = 30): Date {
describe('processMonitorRssFeeds', () => {
beforeEach(() => {
vi.useRealTimers();
vi.clearAllMocks();
// Default to empty blocklist so the filter is a no-op unless a test overrides.
prismaMock.blockedRelease.findMany.mockResolvedValue([]);
@@ -73,6 +74,70 @@ describe('processMonitorRssFeeds', () => {
'req-1',
expect.objectContaining({ title: 'Great Book', author: 'Author Name' })
);
expect(prismaMock.request.findMany).toHaveBeenCalledWith(expect.objectContaining({
orderBy: { id: 'asc' },
take: 100,
}));
});
it('pages beyond the first 100 awaiting requests', async () => {
vi.useFakeTimers();
configMock.get.mockImplementation(async (key: string) => {
if (key === 'prowlarr_indexers') {
return JSON.stringify([{ id: 1, name: 'Indexer', rssEnabled: true }]);
}
return null;
});
prowlarrMock.getAllRssFeeds.mockResolvedValue([
{ title: 'Target Story - Target Author' },
]);
const firstPage = Array.from({ length: 100 }, (_, index) => ({
id: `req-${String(index).padStart(3, '0')}`,
type: 'audiobook',
status: 'awaiting_search',
releaseDate: null,
audiobook: {
id: `a-${index}`,
title: `Unrelated Volume ${index}`,
author: 'Someone Else',
audibleAsin: `ASIN-${index}`,
},
}));
const secondPage = [{
id: 'req-target',
type: 'audiobook',
status: 'awaiting_search',
releaseDate: null,
audiobook: {
id: 'a-target',
title: 'Target Story',
author: 'Target Author',
audibleAsin: 'ASIN-TARGET',
},
}];
prismaMock.request.findMany
.mockResolvedValueOnce(firstPage)
.mockResolvedValueOnce(secondPage);
const { processMonitorRssFeeds } = await import('@/lib/processors/monitor-rss-feeds.processor');
const processing = processMonitorRssFeeds({ jobId: 'job-paged' });
await vi.runAllTimersAsync();
const result = await processing;
expect(result.totalMissing).toBe(101);
expect(result.matched).toBe(1);
expect(prismaMock.request.findMany).toHaveBeenNthCalledWith(2, expect.objectContaining({
orderBy: { id: 'asc' },
cursor: { id: 'req-099' },
skip: 1,
take: 100,
}));
expect(jobQueueMock.addSearchJob).toHaveBeenCalledWith(
'req-target',
expect.objectContaining({ title: 'Target Story', author: 'Target Author' })
);
vi.useRealTimers();
});
it('skips RSS auto-search when matched book is unreleased and setting ON', async () => {
@@ -77,6 +77,18 @@ describe('processRetryFailedImports', () => {
const result = await processRetryFailedImports({ jobId: 'job-1' });
expect(result.success).toBe(true);
expect(prismaMock.request.findMany).toHaveBeenCalledWith(expect.objectContaining({
orderBy: [
{ lastImportAt: { sort: 'asc', nulls: 'first' } },
{ createdAt: 'asc' },
{ id: 'asc' },
],
take: 50,
}));
expect(prismaMock.request.update).toHaveBeenCalledWith({
where: { id: 'req-1' },
data: { lastImportAt: expect.any(Date) },
});
expect(jobQueueMock.addOrganizeJob).toHaveBeenCalledWith(
'req-1',
'a1',
@@ -109,6 +121,10 @@ describe('processRetryFailedImports', () => {
expect(result.skipped).toBe(1);
expect(result.triggered).toBe(0);
expect(prismaMock.request.update).toHaveBeenCalledWith({
where: { id: 'req-2' },
data: { lastImportAt: expect.any(Date) },
});
});
it('falls back to configured download dir when qBittorrent lookup fails', async () => {
@@ -53,6 +53,23 @@ describe('processRetryMissingTorrents', () => {
const result = await processRetryMissingTorrents({ jobId: 'job-1' });
expect(result.success).toBe(true);
expect(prismaMock.request.findMany).toHaveBeenCalledWith({
where: {
deletedAt: null,
OR: [
{ status: 'awaiting_search' },
{ status: 'awaiting_release', releaseDate: null },
{ status: 'awaiting_release', releaseDate: { lte: expect.any(Date) } },
],
},
include: { audiobook: true },
orderBy: [
{ lastSearchAt: { sort: 'asc', nulls: 'first' } },
{ createdAt: 'asc' },
{ id: 'asc' },
],
take: 50,
});
expect(jobQueueMock.addSearchJob).toHaveBeenCalledWith(
'req-1',
expect.objectContaining({ id: 'a1', title: 'Book', author: 'Author' })
@@ -155,5 +172,11 @@ describe('processRetryMissingTorrents', () => {
expect(prismaMock.request.update).not.toHaveBeenCalled();
expect(jobQueueMock.addSearchJob).toHaveBeenCalled();
expect(result.triggered).toBe(1);
expect(prismaMock.request.findMany).toHaveBeenCalledWith(expect.objectContaining({
where: {
deletedAt: null,
status: { in: ['awaiting_search', 'awaiting_release'] },
},
}));
});
});