Add extensible notification providers + UI/API

Introduce a provider-based notification system and wire it through the API and admin UI. Added INotificationProvider + notification service implementation and providers (apprise, discord, ntfy, pushover), plus a GET /api/admin/notifications/providers endpoint to expose provider metadata. Refactored code to use provider type strings (removed enum coupling), updated masking/encryption calls, and simplified the test notification endpoint to accept backendId or type+config and call sendToBackend directly. UI: NotificationsTab now fetches provider metadata and renders provider cards and dynamic config forms (fields driven by provider metadata). Added config field rendering, improved backend cards, and edit/delete actions. APIs: New providers route, updated admin notification CRUD routes to validate provider types dynamically, updated test route schema. Added download-client categories POST API to fetch categories from clients and wired postImportCategory handling in download-client routes. Other notable changes: BookDate now fetches Claude models dynamically from Anthropic's Models API; added paginated model fetch helper. Added ALLOW_WEAK_PASSWORD flag exposure to auth providers and password change logic. Doc updates and various tests added/updated. File-organization doc clarifies EPERM fix using stream-based copy.
2026-06-03 04:40:09 +00:00 · 2026-02-10 15:06:20 -05:00
parent 4a38dd3da8
commit af0eaceb98
73 changed files with 3421 additions and 866 deletions
@@ -16,6 +16,7 @@ interface DownloadClientCardProps {
    url: string;
    enabled: boolean;
    customPath?: string;
+    postImportCategory?: string;
  };
  onEdit: () => void;
  onDelete: () => void;
@@ -62,6 +63,11 @@ export function DownloadClientCard({ client, onEdit, onDelete }: DownloadClientC
                Path: {client.customPath}
              </p>
            )}
+            {client.postImportCategory && (
+              <p className="text-xs text-purple-600 dark:text-purple-400 truncate" title={`Post-import category: ${client.postImportCategory}`}>
+                Post-import: {client.postImportCategory}
+              </p>
+            )}
          </div>
        </div>

@@ -26,6 +26,7 @@ interface DownloadClient {
  localPath?: string;
  category?: string;
  customPath?: string;
+  postImportCategory?: string;
 }

 interface DownloadClientManagementProps {
@@ -72,20 +73,6 @@ export function DownloadClientManagement({
    }
  }, [downloadDirProp]);

-  // Sync with parent when clients change
-  useEffect(() => {
-    if (onClientsChange) {
-      onClientsChange(clients);
-    }
-  }, [clients, onClientsChange]);
-
-  // Sync with initialClients prop changes (wizard mode)
-  useEffect(() => {
-    if (mode === 'wizard') {
-      setClients(initialClients);
-    }
-  }, [initialClients, mode]);
-
  const fetchClients = async () => {
    setLoading(true);
    setError(null);
@@ -172,7 +159,9 @@ export function DownloadClientManagement({
        await fetchClients(); // Refresh list
      } else {
        // Local removal for wizard mode
-        setClients(clients.filter(c => c.id !== deleteConfirm.clientId));
+        const updated = clients.filter(c => c.id !== deleteConfirm.clientId);
+        setClients(updated);
+        onClientsChange?.(updated);
      }

      setDeleteConfirm({ isOpen: false });
@@ -219,15 +208,18 @@ export function DownloadClientManagement({
        }
      } else {
        // Local update for wizard mode
+        let updated: DownloadClient[];
        if (modalState.mode === 'add') {
          const newClient = {
            ...clientData,
            id: `temp-${Date.now()}`, // Temporary ID for wizard mode
          };
-          setClients([...clients, newClient]);
+          updated = [...clients, newClient];
        } else {
-          setClients(clients.map(c => (c.id === clientData.id ? { ...c, ...clientData } : c)));
+          updated = clients.map(c => (c.id === clientData.id ? { ...c, ...clientData } : c));
        }
+        setClients(updated);
+        onClientsChange?.(updated);
      }

      setModalState({ isOpen: false, mode: 'add' });
@@ -10,7 +10,7 @@ import { Modal } from '@/components/ui/Modal';
 import { Button } from '@/components/ui/Button';
 import { Input } from '@/components/ui/Input';
 import { fetchWithAuth } from '@/lib/utils/api';
-import { DownloadClientType, getClientDisplayName } from '@/lib/interfaces/download-client.interface';
+import { DownloadClientType, getClientDisplayName, CLIENT_PROTOCOL_MAP } from '@/lib/interfaces/download-client.interface';

 interface DownloadClientModalProps {
  isOpen: boolean;
@@ -31,6 +31,7 @@ interface DownloadClientModalProps {
    localPath?: string;
    category?: string;
    customPath?: string;
+    postImportCategory?: string;
  };
  onSave: (client: any) => Promise<void>;
  apiMode: 'wizard' | 'settings';
@@ -62,6 +63,9 @@ export function DownloadClientModal({
  const [localPath, setLocalPath] = useState('');
  const [category, setCategory] = useState('readmeabook');
  const [customPath, setCustomPath] = useState('');
+  const [postImportCategory, setPostImportCategory] = useState('');
+  const [availableCategories, setAvailableCategories] = useState<string[]>([]);
+  const [fetchingCategories, setFetchingCategories] = useState(false);

  const [testing, setTesting] = useState(false);
  const [saving, setSaving] = useState(false);
@@ -85,6 +89,7 @@ export function DownloadClientModal({
        setLocalPath(initialClient.localPath || '');
        setCategory(initialClient.category || 'readmeabook');
        setCustomPath(initialClient.customPath || '');
+        setPostImportCategory(initialClient.postImportCategory || '');
      } else {
        // Add mode defaults
        setName(typeName);
@@ -98,9 +103,12 @@ export function DownloadClientModal({
        setLocalPath('');
        setCategory('readmeabook');
        setCustomPath('');
+        setPostImportCategory('');
      }
      setTestResult(null);
      setErrors({});
+      setAvailableCategories([]);
+      setFetchingCategories(false);
    }
  }, [isOpen, mode, initialClient, type]);

@@ -137,6 +145,50 @@ export function DownloadClientModal({
    return Object.keys(newErrors).length === 0;
  };

+  const fetchCategories = async () => {
+    setFetchingCategories(true);
+    try {
+      const isPasswordMasked = password === '********';
+      const categoryData = {
+        type,
+        name,
+        url,
+        username: username || undefined,
+        password: isPasswordMasked ? undefined : password,
+        ...(mode === 'edit' && initialClient && isPasswordMasked ? { clientId: initialClient.id } : {}),
+        disableSSLVerify,
+        remotePathMappingEnabled,
+        remotePath: remotePathMappingEnabled ? remotePath : undefined,
+        localPath: remotePathMappingEnabled ? localPath : undefined,
+      };
+
+      const endpoint = apiMode === 'wizard'
+        ? '/api/setup/download-client-categories'
+        : '/api/admin/settings/download-clients/categories';
+
+      const response = apiMode === 'wizard'
+        ? await fetch(endpoint, {
+            method: 'POST',
+            headers: { 'Content-Type': 'application/json' },
+            body: JSON.stringify(categoryData),
+          })
+        : await fetchWithAuth(endpoint, {
+            method: 'POST',
+            headers: { 'Content-Type': 'application/json' },
+            body: JSON.stringify(categoryData),
+          });
+
+      const data = await response.json();
+      if (response.ok && data.success) {
+        setAvailableCategories(data.categories || []);
+      }
+    } catch {
+      // Non-critical — categories are optional
+    } finally {
+      setFetchingCategories(false);
+    }
+  };
+
  const handleTestConnection = async () => {
    if (!validate()) {
      return;
@@ -187,6 +239,11 @@ export function DownloadClientModal({
        // Handle both endpoint response formats (settings returns message, wizard returns version)
        const message = data.message || (data.version ? `Connected successfully (v${data.version})` : 'Connection successful');
        setTestResult({ success: true, message });
+
+        // Fetch categories for torrent clients after successful connection
+        if (type && CLIENT_PROTOCOL_MAP[type] === 'torrent') {
+          fetchCategories();
+        }
      } else {
        setTestResult({ success: false, message: data.error || 'Connection test failed' });
      }
@@ -230,6 +287,7 @@ export function DownloadClientModal({
        localPath: remotePathMappingEnabled ? localPath : undefined,
        category,
        customPath: sanitizedCustomPath || undefined,
+        postImportCategory,
      };

      if (mode === 'edit' && initialClient) {
@@ -384,6 +442,37 @@ export function DownloadClientModal({
          </p>
        </div>

+        {/* Post-Import Category (torrent clients only) */}
+        {type && CLIENT_PROTOCOL_MAP[type] === 'torrent' && (
+          <div>
+            <label className="block text-sm font-medium text-gray-700 dark:text-gray-300 mb-1">
+              Post-Import Category
+            </label>
+            {type === 'qbittorrent' && availableCategories.length > 0 ? (
+              <select
+                value={postImportCategory}
+                onChange={(e) => setPostImportCategory(e.target.value)}
+                className="w-full rounded-md border border-gray-300 dark:border-gray-600 bg-white dark:bg-gray-700 text-gray-900 dark:text-gray-100 px-3 py-2 text-sm focus:outline-none focus:ring-2 focus:ring-blue-500 focus:border-transparent"
+              >
+                <option value="">None (keep original)</option>
+                {availableCategories.map((cat) => (
+                  <option key={cat} value={cat}>{cat}</option>
+                ))}
+              </select>
+            ) : (
+              <Input
+                value={postImportCategory}
+                onChange={(e) => setPostImportCategory(e.target.value)}
+                placeholder="e.g. completed"
+                disabled={fetchingCategories}
+              />
+            )}
+            <p className="mt-1 text-xs text-gray-500 dark:text-gray-400">
+              After import, change the download&apos;s category/label in the client. Leave empty to skip.
+            </p>
+          </div>
+        )}
+
        {/* Remote Path Mapping */}
        <div className="border-t border-gray-200 dark:border-gray-700 pt-4">
          <div className="flex items-start mb-3">
@@ -63,17 +63,14 @@ export function IndexerManagement({
  const [loading, setLoading] = useState(false);
  const [error, setError] = useState<string | null>(null);

-  // Sync with parent when configuredIndexers changes
+  // In settings mode, the parent fetches indexers asynchronously and passes them
+  // as initialIndexers after mount. This effect picks up that late-arriving data.
+  // Wizard mode doesn't need this — it initializes correctly via useState above.
  useEffect(() => {
-    if (onIndexersChange) {
-      onIndexersChange(configuredIndexers);
+    if (mode === 'settings') {
+      setConfiguredIndexers(initialIndexers);
    }
-  }, [configuredIndexers, onIndexersChange]);
-
-  // Sync with initialIndexers prop changes
-  useEffect(() => {
-    setConfiguredIndexers(initialIndexers);
-  }, [initialIndexers]);
+  }, [initialIndexers, mode]);

  const fetchIndexers = async () => {
    setLoading(true);
@@ -149,17 +146,16 @@ export function IndexerManagement({
  };

  const handleSave = (config: SavedIndexerConfig) => {
+    let updated: SavedIndexerConfig[];
    if (modalState.mode === 'add') {
-      // Add new indexer
-      setConfiguredIndexers([...configuredIndexers, config]);
+      updated = [...configuredIndexers, config];
    } else {
-      // Update existing indexer
-      setConfiguredIndexers(
-        configuredIndexers.map((idx) =>
-          idx.id === config.id ? config : idx
-        )
+      updated = configuredIndexers.map((idx) =>
+        idx.id === config.id ? config : idx
      );
    }
+    setConfiguredIndexers(updated);
+    onIndexersChange?.(updated);
  };

  const handleDelete = (id: number) => {
@@ -175,9 +171,9 @@ export function IndexerManagement({

  const confirmDelete = () => {
    if (deleteModalState.indexerId) {
-      setConfiguredIndexers(
-        configuredIndexers.filter((idx) => idx.id !== deleteModalState.indexerId)
-      );
+      const updated = configuredIndexers.filter((idx) => idx.id !== deleteModalState.indexerId);
+      setConfiguredIndexers(updated);
+      onIndexersChange?.(updated);
    }
  };

@@ -5,7 +5,7 @@

 'use client';

-import React, { useState } from 'react';
+import React, { useState, useEffect } from 'react';
 import { Modal } from './Modal';
 import { Input } from './Input';
 import { Button } from './Button';
@@ -22,6 +22,24 @@ export function ChangePasswordModal({ isOpen, onClose }: ChangePasswordModalProp
  const [loading, setLoading] = useState(false);
  const [error, setError] = useState<string | null>(null);
  const [success, setSuccess] = useState(false);
+  const [allowWeakPassword, setAllowWeakPassword] = useState(false);
+
+  // Fetch password policy when modal opens
+  useEffect(() => {
+    if (!isOpen) return;
+    const fetchPolicy = async () => {
+      try {
+        const response = await fetch('/api/auth/providers');
+        if (response.ok) {
+          const data = await response.json();
+          setAllowWeakPassword(data.allowWeakPassword === true);
+        }
+      } catch {
+        // Default to strict validation on error
+      }
+    };
+    fetchPolicy();
+  }, [isOpen]);

  // Validation errors for individual fields
  const [errors, setErrors] = useState({
@@ -47,7 +65,7 @@ export function ChangePasswordModal({ isOpen, onClose }: ChangePasswordModalProp
    if (!newPassword) {
      newErrors.newPassword = 'New password is required';
      isValid = false;
-    } else if (newPassword.length < 8) {
+    } else if (!allowWeakPassword && newPassword.length < 8) {
      newErrors.newPassword = 'Password must be at least 8 characters';
      isValid = false;
    } else if (newPassword === currentPassword) {
@@ -211,7 +229,7 @@ export function ChangePasswordModal({ isOpen, onClose }: ChangePasswordModalProp
          }}
          placeholder="Enter your new password"
          autoComplete="new-password"
-          helperText="Must be at least 8 characters"
+          helperText={allowWeakPassword ? undefined : 'Must be at least 8 characters'}
          error={errors.newPassword}
          disabled={loading || success}
        />