Fix token handling, modal behavior, and pagination

Multiple fixes and improvements:

- src/app/api/user/hardcover-shelves/[id]/route.ts: Make token testing more robust by using the existing shelf.apiToken when no new token is provided, attempt decryption only when needed, and gracefully fall back on decryption errors.
- src/components/ui/AddShelfModal.tsx: Simplify token handling by passing the trimmed token directly to addHardcover (remove client-side 'Bearer ' stripping).
- src/components/ui/ManageShelfModal.tsx: Stabilize form reset effect by depending on shelf?.id to avoid unnecessary re-renders when the shelf object changes identity.
- src/components/ui/Modal.tsx: Simplify modal rendering by removing the mounted state and createPortal usage, cleaning up imports and rendering directly.
- src/lib/services/hardcover-api.service.ts: Add a logger, introduce a MAX_PAGES cap and page counters to prevent unbounded pagination loops, and log/break when the API returns errors during pagination.

These changes improve reliability (token handling and pagination safety), reduce unnecessary renders, and simplify modal lifecycle.
This commit is contained in:
kikootwo
2026-03-04 10:55:37 -05:00
parent 7f706e806f
commit c29cfa3a07
5 changed files with 31 additions and 30 deletions
+14 -3
View File
@@ -7,7 +7,9 @@
*/
import axios from 'axios';
import { RMABLogger } from '@/lib/utils/logger';
const logger = RMABLogger.create('HardcoverAPI');
const HARDCOVER_API_URL = 'https://api.hardcover.app/v1/graphql';
export interface HardcoverApiBook {
@@ -33,6 +35,7 @@ interface HardcoverListData {
}
const PAGE_SIZE = 100;
const MAX_PAGES = 50;
/** Extract HardcoverApiBook[] from an array of book-containing items */
function extractBooks(items: Array<{ book?: HardcoverBookNode }>): HardcoverApiBook[] {
@@ -106,9 +109,10 @@ export async function fetchHardcoverList(
const allBooks: HardcoverApiBook[] = [];
let offset = 0;
let page = 0;
// Paginate until fewer results than PAGE_SIZE are returned
while (true) {
while (++page <= MAX_PAGES) {
const response = await axios.post(
HARDCOVER_API_URL,
{ query, variables: { statusId, limit: PAGE_SIZE, offset } },
@@ -274,8 +278,9 @@ export async function fetchHardcoverList(
// Paginate if first page was full
if (firstPageItems.length >= PAGE_SIZE) {
let offset = PAGE_SIZE;
let page = 1; // first page already fetched
while (true) {
while (++page <= MAX_PAGES) {
const pageResponse = await axios.post(
HARDCOVER_API_URL,
{
@@ -291,7 +296,13 @@ export async function fetchHardcoverList(
},
);
if (pageResponse.data?.errors) break;
if (pageResponse.data?.errors) {
logger.warn('Hardcover pagination interrupted by API error', {
errors: pageResponse.data.errors,
offset,
});
break;
}
let pageListsData: HardcoverListData[];
if (isIntId) {