mirror of
https://github.com/kikootwo/ReadMeABook.git
synced 2026-06-02 20:30:10 +00:00
31bca0052f
Introduces 'series' and 'seriesPart' fields to the Audiobook model and database schema. Updates API routes, file organization, and path template utilities to support series metadata. Enhances chapter merging logic, improves notification backend testing, and expands test coverage for admin and API routes.
388 lines
14 KiB
TypeScript
388 lines
14 KiB
TypeScript
/**
|
|
* Component: Admin Users API Route Tests
|
|
* Documentation: documentation/testing.md
|
|
*/
|
|
|
|
import { beforeEach, describe, expect, it, vi } from 'vitest';
|
|
import { createPrismaMock } from '../helpers/prisma';
|
|
|
|
let authRequest: any;
|
|
|
|
const prismaMock = createPrismaMock();
|
|
const requireAuthMock = vi.hoisted(() => vi.fn());
|
|
const requireAdminMock = vi.hoisted(() => vi.fn());
|
|
|
|
vi.mock('@/lib/db', () => ({
|
|
prisma: prismaMock,
|
|
}));
|
|
|
|
vi.mock('@/lib/middleware/auth', () => ({
|
|
requireAuth: requireAuthMock,
|
|
requireAdmin: requireAdminMock,
|
|
}));
|
|
|
|
describe('Admin users routes', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
authRequest = { user: { sub: 'admin-1', role: 'admin' }, json: vi.fn() };
|
|
requireAuthMock.mockImplementation((_req: any, handler: any) => handler(authRequest));
|
|
requireAdminMock.mockImplementation((_req: any, handler: any) => handler());
|
|
});
|
|
|
|
it('returns users list', async () => {
|
|
prismaMock.user.findMany.mockResolvedValueOnce([{ id: 'u1' }]);
|
|
|
|
const { GET } = await import('@/app/api/admin/users/route');
|
|
const response = await GET({} as any);
|
|
const payload = await response.json();
|
|
|
|
expect(payload.users).toHaveLength(1);
|
|
});
|
|
|
|
it('returns pending users list', async () => {
|
|
prismaMock.user.findMany.mockResolvedValueOnce([{ id: 'u2' }]);
|
|
|
|
const { GET } = await import('@/app/api/admin/users/pending/route');
|
|
const response = await GET({} as any);
|
|
const payload = await response.json();
|
|
|
|
expect(payload.users).toHaveLength(1);
|
|
});
|
|
|
|
it('updates a user role', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValueOnce({
|
|
isSetupAdmin: false,
|
|
authProvider: 'local',
|
|
plexUsername: 'user',
|
|
deletedAt: null,
|
|
role: 'user',
|
|
});
|
|
prismaMock.user.update.mockResolvedValueOnce({ id: 'u3', plexUsername: 'user', role: 'admin' });
|
|
const request = { json: vi.fn().mockResolvedValue({ role: 'admin' }) };
|
|
|
|
const { PUT } = await import('@/app/api/admin/users/[id]/route');
|
|
const response = await PUT(request as any, { params: Promise.resolve({ id: 'u3' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(payload.user.role).toBe('admin');
|
|
});
|
|
|
|
it('rejects invalid roles', async () => {
|
|
const request = { json: vi.fn().mockResolvedValue({ role: 'owner' }) };
|
|
|
|
const { PUT } = await import('@/app/api/admin/users/[id]/route');
|
|
const response = await PUT(request as any, { params: Promise.resolve({ id: 'u3' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(400);
|
|
expect(payload.error).toMatch(/Invalid role/);
|
|
});
|
|
|
|
it('rejects invalid autoApproveRequests values', async () => {
|
|
const request = { json: vi.fn().mockResolvedValue({ role: 'user', autoApproveRequests: 'yes' }) };
|
|
|
|
const { PUT } = await import('@/app/api/admin/users/[id]/route');
|
|
const response = await PUT(request as any, { params: Promise.resolve({ id: 'u3' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(400);
|
|
expect(payload.error).toMatch(/autoApproveRequests/);
|
|
});
|
|
|
|
it('prevents changing your own role', async () => {
|
|
const request = { json: vi.fn().mockResolvedValue({ role: 'user' }) };
|
|
|
|
const { PUT } = await import('@/app/api/admin/users/[id]/route');
|
|
const response = await PUT(request as any, { params: Promise.resolve({ id: 'admin-1' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(403);
|
|
expect(payload.error).toMatch(/cannot change your own role/i);
|
|
});
|
|
|
|
it('returns 404 when updating a missing user', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValueOnce(null);
|
|
const request = { json: vi.fn().mockResolvedValue({ role: 'admin' }) };
|
|
|
|
const { PUT } = await import('@/app/api/admin/users/[id]/route');
|
|
const response = await PUT(request as any, { params: Promise.resolve({ id: 'missing' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(404);
|
|
expect(payload.error).toMatch(/User not found/);
|
|
});
|
|
|
|
it('prevents modifying deleted users', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValueOnce({
|
|
isSetupAdmin: false,
|
|
authProvider: 'local',
|
|
plexUsername: 'user',
|
|
deletedAt: new Date(),
|
|
role: 'user',
|
|
});
|
|
const request = { json: vi.fn().mockResolvedValue({ role: 'admin' }) };
|
|
|
|
const { PUT } = await import('@/app/api/admin/users/[id]/route');
|
|
const response = await PUT(request as any, { params: Promise.resolve({ id: 'u3' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(403);
|
|
expect(payload.error).toMatch(/deleted user/);
|
|
});
|
|
|
|
it('prevents changing setup admin role', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValueOnce({
|
|
isSetupAdmin: true,
|
|
authProvider: 'local',
|
|
plexUsername: 'setup-admin',
|
|
deletedAt: null,
|
|
role: 'admin',
|
|
});
|
|
const request = { json: vi.fn().mockResolvedValue({ role: 'user' }) };
|
|
|
|
const { PUT } = await import('@/app/api/admin/users/[id]/route');
|
|
const response = await PUT(request as any, { params: Promise.resolve({ id: 'setup-1' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(403);
|
|
expect(payload.error).toMatch(/setup admin role/);
|
|
});
|
|
|
|
it('rejects admin role with autoApproveRequests false', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValueOnce({
|
|
isSetupAdmin: false,
|
|
authProvider: 'local',
|
|
plexUsername: 'admin',
|
|
deletedAt: null,
|
|
role: 'admin',
|
|
});
|
|
const request = { json: vi.fn().mockResolvedValue({ role: 'admin', autoApproveRequests: false }) };
|
|
|
|
const { PUT } = await import('@/app/api/admin/users/[id]/route');
|
|
const response = await PUT(request as any, { params: Promise.resolve({ id: 'admin-2' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(400);
|
|
expect(payload.error).toMatch(/auto-approve requests/);
|
|
});
|
|
|
|
it('allows autoApproveRequests update for OIDC users without role change', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValueOnce({
|
|
isSetupAdmin: false,
|
|
authProvider: 'oidc',
|
|
plexUsername: 'oidc-user',
|
|
deletedAt: null,
|
|
role: 'user',
|
|
});
|
|
prismaMock.user.update.mockResolvedValueOnce({
|
|
id: 'oidc-1',
|
|
plexUsername: 'oidc-user',
|
|
role: 'user',
|
|
autoApproveRequests: true,
|
|
});
|
|
const request = { json: vi.fn().mockResolvedValue({ role: 'user', autoApproveRequests: true }) };
|
|
|
|
const { PUT } = await import('@/app/api/admin/users/[id]/route');
|
|
const response = await PUT(request as any, { params: Promise.resolve({ id: 'oidc-1' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(200);
|
|
expect(payload.user.autoApproveRequests).toBe(true);
|
|
});
|
|
|
|
it('prevents OIDC user role change', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValueOnce({
|
|
isSetupAdmin: false,
|
|
authProvider: 'oidc',
|
|
plexUsername: 'oidc-user',
|
|
deletedAt: null,
|
|
role: 'user',
|
|
});
|
|
const request = { json: vi.fn().mockResolvedValue({ role: 'admin', autoApproveRequests: true }) };
|
|
|
|
const { PUT } = await import('@/app/api/admin/users/[id]/route');
|
|
const response = await PUT(request as any, { params: Promise.resolve({ id: 'oidc-1' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(403);
|
|
expect(payload.error).toContain('OIDC');
|
|
});
|
|
|
|
it('allows autoApproveRequests update for setup admin without role change', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValueOnce({
|
|
isSetupAdmin: true,
|
|
authProvider: 'local',
|
|
plexUsername: 'setup-admin',
|
|
deletedAt: null,
|
|
role: 'admin',
|
|
});
|
|
prismaMock.user.update.mockResolvedValueOnce({
|
|
id: 'setup-1',
|
|
plexUsername: 'setup-admin',
|
|
role: 'admin',
|
|
autoApproveRequests: true,
|
|
});
|
|
const request = { json: vi.fn().mockResolvedValue({ role: 'admin', autoApproveRequests: true }) };
|
|
|
|
const { PUT } = await import('@/app/api/admin/users/[id]/route');
|
|
const response = await PUT(request as any, { params: Promise.resolve({ id: 'setup-1' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(200);
|
|
expect(payload.user.autoApproveRequests).toBe(true);
|
|
});
|
|
|
|
it('soft deletes a local user', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValueOnce({
|
|
id: 'u4',
|
|
plexUsername: 'user',
|
|
isSetupAdmin: false,
|
|
authProvider: 'local',
|
|
deletedAt: null,
|
|
_count: { requests: 1 },
|
|
});
|
|
prismaMock.user.update.mockResolvedValueOnce({});
|
|
|
|
const { DELETE } = await import('@/app/api/admin/users/[id]/route');
|
|
const response = await DELETE({} as any, { params: Promise.resolve({ id: 'u4' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(payload.success).toBe(true);
|
|
});
|
|
|
|
it('prevents deleting yourself', async () => {
|
|
const { DELETE } = await import('@/app/api/admin/users/[id]/route');
|
|
const response = await DELETE({} as any, { params: Promise.resolve({ id: 'admin-1' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(403);
|
|
expect(payload.error).toMatch(/delete your own account/);
|
|
});
|
|
|
|
it('returns 404 when deleting a missing user', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValueOnce(null);
|
|
|
|
const { DELETE } = await import('@/app/api/admin/users/[id]/route');
|
|
const response = await DELETE({} as any, { params: Promise.resolve({ id: 'missing' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(404);
|
|
expect(payload.error).toMatch(/User not found/);
|
|
});
|
|
|
|
it('returns 400 when deleting an already deleted user', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValueOnce({
|
|
id: 'u4',
|
|
plexUsername: 'user',
|
|
isSetupAdmin: false,
|
|
authProvider: 'local',
|
|
deletedAt: new Date(),
|
|
_count: { requests: 1 },
|
|
});
|
|
|
|
const { DELETE } = await import('@/app/api/admin/users/[id]/route');
|
|
const response = await DELETE({} as any, { params: Promise.resolve({ id: 'u4' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(400);
|
|
expect(payload.error).toMatch(/already been deleted/);
|
|
});
|
|
|
|
it('prevents deleting setup admin users', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValueOnce({
|
|
id: 'setup-1',
|
|
plexUsername: 'setup-admin',
|
|
isSetupAdmin: true,
|
|
authProvider: 'local',
|
|
deletedAt: null,
|
|
_count: { requests: 2 },
|
|
});
|
|
|
|
const { DELETE } = await import('@/app/api/admin/users/[id]/route');
|
|
const response = await DELETE({} as any, { params: Promise.resolve({ id: 'setup-1' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(403);
|
|
expect(payload.error).toMatch(/setup admin/);
|
|
});
|
|
|
|
it('prevents deleting non-local users', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValueOnce({
|
|
id: 'plex-1',
|
|
plexUsername: 'plexuser',
|
|
isSetupAdmin: false,
|
|
authProvider: 'plex',
|
|
deletedAt: null,
|
|
_count: { requests: 0 },
|
|
});
|
|
|
|
const { DELETE } = await import('@/app/api/admin/users/[id]/route');
|
|
const response = await DELETE({} as any, { params: Promise.resolve({ id: 'plex-1' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(403);
|
|
expect(payload.error).toMatch(/Cannot delete Plex users/);
|
|
});
|
|
|
|
it('approves a pending user', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValueOnce({
|
|
id: 'u5',
|
|
plexUsername: 'user',
|
|
registrationStatus: 'pending_approval',
|
|
});
|
|
prismaMock.user.update.mockResolvedValueOnce({});
|
|
const request = { json: vi.fn().mockResolvedValue({ approve: true }) };
|
|
|
|
const { POST } = await import('@/app/api/admin/users/[id]/approve/route');
|
|
const response = await POST(request as any, { params: Promise.resolve({ id: 'u5' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(payload.success).toBe(true);
|
|
});
|
|
|
|
it('returns 404 when approving a missing user', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValueOnce(null);
|
|
const request = { json: vi.fn().mockResolvedValue({ approve: true }) };
|
|
|
|
const { POST } = await import('@/app/api/admin/users/[id]/approve/route');
|
|
const response = await POST(request as any, { params: Promise.resolve({ id: 'missing' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(404);
|
|
expect(payload.error).toMatch(/not found/i);
|
|
});
|
|
|
|
it('returns 400 when user is not pending approval', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValueOnce({
|
|
id: 'u6',
|
|
plexUsername: 'user',
|
|
registrationStatus: 'approved',
|
|
});
|
|
const request = { json: vi.fn().mockResolvedValue({ approve: true }) };
|
|
|
|
const { POST } = await import('@/app/api/admin/users/[id]/approve/route');
|
|
const response = await POST(request as any, { params: Promise.resolve({ id: 'u6' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(400);
|
|
expect(payload.error).toMatch(/not pending/);
|
|
});
|
|
|
|
it('rejects a pending user when approve is false', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValueOnce({
|
|
id: 'u7',
|
|
plexUsername: 'user',
|
|
registrationStatus: 'pending_approval',
|
|
});
|
|
prismaMock.user.delete.mockResolvedValueOnce({});
|
|
const request = { json: vi.fn().mockResolvedValue({ approve: false }) };
|
|
|
|
const { POST } = await import('@/app/api/admin/users/[id]/approve/route');
|
|
const response = await POST(request as any, { params: Promise.resolve({ id: 'u7' }) });
|
|
const payload = await response.json();
|
|
|
|
expect(payload.success).toBe(true);
|
|
expect(payload.message).toMatch(/rejected/);
|
|
});
|
|
});
|