mirror of
https://github.com/kikootwo/ReadMeABook.git
synced 2026-06-02 20:30:10 +00:00
af0eaceb98
Introduce a provider-based notification system and wire it through the API and admin UI. Added INotificationProvider + notification service implementation and providers (apprise, discord, ntfy, pushover), plus a GET /api/admin/notifications/providers endpoint to expose provider metadata. Refactored code to use provider type strings (removed enum coupling), updated masking/encryption calls, and simplified the test notification endpoint to accept backendId or type+config and call sendToBackend directly. UI: NotificationsTab now fetches provider metadata and renders provider cards and dynamic config forms (fields driven by provider metadata). Added config field rendering, improved backend cards, and edit/delete actions. APIs: New providers route, updated admin notification CRUD routes to validate provider types dynamically, updated test route schema. Added download-client categories POST API to fetch categories from clients and wired postImportCategory handling in download-client routes. Other notable changes: BookDate now fetches Claude models dynamically from Anthropic's Models API; added paginated model fetch helper. Added ALLOW_WEAK_PASSWORD flag exposure to auth providers and password change logic. Doc updates and various tests added/updated. File-organization doc clarifies EPERM fix using stream-based copy.
188 lines
5.8 KiB
TypeScript
188 lines
5.8 KiB
TypeScript
/**
|
|
* Component: Change Password API Route Tests
|
|
* Documentation: documentation/backend/services/auth.md
|
|
*/
|
|
|
|
import { beforeEach, describe, expect, it, vi } from 'vitest';
|
|
import { createPrismaMock } from '../helpers/prisma';
|
|
|
|
const prismaMock = createPrismaMock();
|
|
const bcryptMock = {
|
|
compare: vi.fn(),
|
|
hash: vi.fn(),
|
|
};
|
|
const encryptionMock = {
|
|
decrypt: vi.fn(),
|
|
encrypt: vi.fn(),
|
|
};
|
|
const requireAuthMock = vi.fn();
|
|
|
|
vi.mock('@/lib/db', () => ({
|
|
prisma: prismaMock,
|
|
}));
|
|
|
|
vi.mock('bcrypt', () => ({
|
|
default: bcryptMock,
|
|
...bcryptMock,
|
|
}));
|
|
|
|
vi.mock('@/lib/services/encryption.service', () => ({
|
|
getEncryptionService: () => encryptionMock,
|
|
}));
|
|
|
|
vi.mock('@/lib/middleware/auth', () => ({
|
|
requireAuth: requireAuthMock,
|
|
}));
|
|
|
|
const makeRequest = (body: Record<string, any>) => ({
|
|
json: vi.fn().mockResolvedValue(body),
|
|
});
|
|
|
|
describe('Change password route', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks();
|
|
requireAuthMock.mockImplementation((_req: any, handler: any) =>
|
|
handler({ user: { id: 'user-1' } })
|
|
);
|
|
});
|
|
|
|
it('validates required fields', async () => {
|
|
const { POST } = await import('@/app/api/auth/change-password/route');
|
|
|
|
const response = await POST(makeRequest({ currentPassword: 'old' }) as any);
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(400);
|
|
expect(payload.error).toMatch(/required/i);
|
|
});
|
|
|
|
it('rejects short passwords', async () => {
|
|
const { POST } = await import('@/app/api/auth/change-password/route');
|
|
|
|
const response = await POST(
|
|
makeRequest({ currentPassword: 'old', newPassword: 'short', confirmPassword: 'short' }) as any
|
|
);
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(400);
|
|
expect(payload.error).toMatch(/at least 8 characters/i);
|
|
});
|
|
|
|
it('allows short passwords when ALLOW_WEAK_PASSWORD is enabled', async () => {
|
|
process.env.ALLOW_WEAK_PASSWORD = 'true';
|
|
prismaMock.user.findUnique.mockResolvedValue({
|
|
id: 'user-1',
|
|
authProvider: 'local',
|
|
authToken: 'enc-hash',
|
|
plexId: 'local-user',
|
|
plexUsername: 'user',
|
|
});
|
|
encryptionMock.decrypt.mockReturnValue('hash');
|
|
bcryptMock.compare.mockResolvedValue(true);
|
|
bcryptMock.hash.mockResolvedValue('new-hash');
|
|
encryptionMock.encrypt.mockReturnValue('enc-new-hash');
|
|
prismaMock.user.update.mockResolvedValue({});
|
|
const { POST } = await import('@/app/api/auth/change-password/route');
|
|
|
|
const response = await POST(
|
|
makeRequest({ currentPassword: 'oldpass', newPassword: 'ab', confirmPassword: 'ab' }) as any
|
|
);
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(200);
|
|
expect(payload.success).toBe(true);
|
|
delete process.env.ALLOW_WEAK_PASSWORD;
|
|
});
|
|
|
|
it('blocks non-local users', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValue({
|
|
id: 'user-1',
|
|
authProvider: 'plex',
|
|
authToken: 'enc-hash',
|
|
plexId: 'plex-1',
|
|
plexUsername: 'user',
|
|
});
|
|
const { POST } = await import('@/app/api/auth/change-password/route');
|
|
|
|
const response = await POST(
|
|
makeRequest({ currentPassword: 'oldpass', newPassword: 'newpass123', confirmPassword: 'newpass123' }) as any
|
|
);
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(403);
|
|
expect(payload.error).toMatch(/local users/i);
|
|
});
|
|
|
|
it('rejects incorrect current password', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValue({
|
|
id: 'user-1',
|
|
authProvider: 'local',
|
|
authToken: 'enc-hash',
|
|
plexId: 'local-user',
|
|
plexUsername: 'user',
|
|
});
|
|
encryptionMock.decrypt.mockReturnValue('hash');
|
|
bcryptMock.compare.mockResolvedValue(false);
|
|
const { POST } = await import('@/app/api/auth/change-password/route');
|
|
|
|
const response = await POST(
|
|
makeRequest({ currentPassword: 'wrong', newPassword: 'newpass123', confirmPassword: 'newpass123' }) as any
|
|
);
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(400);
|
|
expect(payload.error).toMatch(/incorrect/i);
|
|
});
|
|
|
|
it('returns error when decryption fails', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValue({
|
|
id: 'user-1',
|
|
authProvider: 'local',
|
|
authToken: 'enc-hash',
|
|
plexId: 'local-user',
|
|
plexUsername: 'user',
|
|
});
|
|
encryptionMock.decrypt.mockImplementation(() => {
|
|
throw new Error('decrypt failed');
|
|
});
|
|
const { POST } = await import('@/app/api/auth/change-password/route');
|
|
|
|
const response = await POST(
|
|
makeRequest({ currentPassword: 'oldpass', newPassword: 'newpass123', confirmPassword: 'newpass123' }) as any
|
|
);
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(500);
|
|
expect(payload.error).toMatch(/verify current password/i);
|
|
});
|
|
|
|
it('updates password for local user', async () => {
|
|
prismaMock.user.findUnique.mockResolvedValue({
|
|
id: 'user-1',
|
|
authProvider: 'local',
|
|
authToken: 'enc-hash',
|
|
plexId: 'local-user',
|
|
plexUsername: 'user',
|
|
});
|
|
encryptionMock.decrypt.mockReturnValue('hash');
|
|
bcryptMock.compare.mockResolvedValue(true);
|
|
bcryptMock.hash.mockResolvedValue('new-hash');
|
|
encryptionMock.encrypt.mockReturnValue('enc-new-hash');
|
|
prismaMock.user.update.mockResolvedValue({});
|
|
const { POST } = await import('@/app/api/auth/change-password/route');
|
|
|
|
const response = await POST(
|
|
makeRequest({ currentPassword: 'oldpass', newPassword: 'newpass123', confirmPassword: 'newpass123' }) as any
|
|
);
|
|
const payload = await response.json();
|
|
|
|
expect(response.status).toBe(200);
|
|
expect(payload.success).toBe(true);
|
|
expect(prismaMock.user.update).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
data: expect.objectContaining({ authToken: 'enc-new-hash' }),
|
|
})
|
|
);
|
|
});
|
|
});
|