From 004df2f852a44ce6a7a6cff7999d56a1e2a43cb5 Mon Sep 17 00:00:00 2001 From: Stavros Date: Mon, 4 May 2026 16:14:45 +0300 Subject: [PATCH] chore: rename get basic auth to encode basic auth for clarity --- internal/controller/proxy_controller.go | 2 +- internal/utils/security_utils.go | 2 +- internal/utils/security_utils_test.go | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/internal/controller/proxy_controller.go b/internal/controller/proxy_controller.go index 014c9db6..c4d97643 100644 --- a/internal/controller/proxy_controller.go +++ b/internal/controller/proxy_controller.go @@ -314,7 +314,7 @@ func (controller *ProxyController) setHeaders(c *gin.Context, acls model.App) { if acls.Response.BasicAuth.Username != "" && basicPassword != "" { tlog.App.Debug().Str("username", acls.Response.BasicAuth.Username).Msg("Setting basic auth header") - c.Header("Authorization", fmt.Sprintf("Basic %s", utils.GetBasicAuth(acls.Response.BasicAuth.Username, basicPassword))) + c.Header("Authorization", fmt.Sprintf("Basic %s", utils.EncodeBasicAuth(acls.Response.BasicAuth.Username, basicPassword))) } } diff --git a/internal/utils/security_utils.go b/internal/utils/security_utils.go index 1b8d8e9f..abfdbfe8 100644 --- a/internal/utils/security_utils.go +++ b/internal/utils/security_utils.go @@ -41,7 +41,7 @@ func ParseSecretFile(contents string) string { return "" } -func GetBasicAuth(username string, password string) string { +func EncodeBasicAuth(username string, password string) string { auth := username + ":" + password return base64.StdEncoding.EncodeToString([]byte(auth)) } diff --git a/internal/utils/security_utils_test.go b/internal/utils/security_utils_test.go index 48c37335..36f1e8bc 100644 --- a/internal/utils/security_utils_test.go +++ b/internal/utils/security_utils_test.go @@ -55,24 +55,24 @@ func TestParseSecretFile(t *testing.T) { assert.Equal(t, "", utils.ParseSecretFile(content)) } -func TestGetBasicAuth(t *testing.T) { +func TestEncodeBasicAuth(t *testing.T) { // Normal case username := "user" password := "pass" expected := "dXNlcjpwYXNz" // base64 of "user:pass" - assert.Equal(t, expected, utils.GetBasicAuth(username, password)) + assert.Equal(t, expected, utils.EncodeBasicAuth(username, password)) // Empty username username = "" password = "pass" expected = "OnBhc3M=" // base64 of ":pass" - assert.Equal(t, expected, utils.GetBasicAuth(username, password)) + assert.Equal(t, expected, utils.EncodeBasicAuth(username, password)) // Empty password username = "user" password = "" expected = "dXNlcjo=" // base64 of "user:" - assert.Equal(t, expected, utils.GetBasicAuth(username, password)) + assert.Equal(t, expected, utils.EncodeBasicAuth(username, password)) } func TestFilterIP(t *testing.T) {