From 02b48aa1657eca99f22a641f3e3989c51bab9e80 Mon Sep 17 00:00:00 2001 From: Stavros Date: Sat, 9 May 2026 13:42:44 +0300 Subject: [PATCH] fix: fix typos --- internal/bootstrap/app_bootstrap.go | 10 +++++----- internal/bootstrap/service_bootstrap.go | 2 +- internal/controller/user_controller.go | 2 +- internal/model/context.go | 2 +- internal/service/access_controls_service.go | 6 +++--- internal/service/auth_service.go | 6 ------ internal/utils/logger/logger.go | 2 +- 7 files changed, 12 insertions(+), 18 deletions(-) diff --git a/internal/bootstrap/app_bootstrap.go b/internal/bootstrap/app_bootstrap.go index 48d57a9d..36afb79a 100644 --- a/internal/bootstrap/app_bootstrap.go +++ b/internal/bootstrap/app_bootstrap.go @@ -214,7 +214,7 @@ func (app *BootstrapApp) Setup() error { return errors.New("no authentication providers configured") } - for _, provider := range app.runtime.ConfiguredProviders { + for _, provider := range configuredProviders { app.log.App.Debug().Str("provider", provider.Name).Msg("Configured authentication provider") } @@ -238,7 +238,7 @@ func (app *BootstrapApp) Setup() error { } // create err channel to listen for server errors - errChan := make(chan error, 1) + errChan := make(chan error, 2) // serve unix app.wg.Go(func() { @@ -317,7 +317,7 @@ func (app *BootstrapApp) serveUnix() error { listener, err := net.Listen("unix", app.config.Server.SocketPath) if err != nil { - return fmt.Errorf("failed to create unix socket listner: %w", err) + return fmt.Errorf("failed to create unix socket listener: %w", err) } server := &http.Server{ @@ -330,7 +330,7 @@ func (app *BootstrapApp) serveUnix() error { go func() { <-app.ctx.Done() - app.log.App.Debug().Msg("Shutting down unix sokcet listener") + app.log.App.Debug().Msg("Shutting down unix socket listener") server.Close() listener.Close() os.Remove(app.config.Server.SocketPath) @@ -338,7 +338,7 @@ func (app *BootstrapApp) serveUnix() error { err = server.Serve(listener) - if err != nil && (!errors.Is(err, net.ErrClosed) || !errors.Is(err, http.ErrServerClosed)) { + if err != nil && !errors.Is(err, net.ErrClosed) && !errors.Is(err, http.ErrServerClosed) { return fmt.Errorf("failed to start unix socket listener: %w", err) } diff --git a/internal/bootstrap/service_bootstrap.go b/internal/bootstrap/service_bootstrap.go index 1e850437..ef3ee591 100644 --- a/internal/bootstrap/service_bootstrap.go +++ b/internal/bootstrap/service_bootstrap.go @@ -19,7 +19,7 @@ func (app *BootstrapApp) setupServices() error { useKubernetes := app.config.LabelProvider == "kubernetes" || (app.config.LabelProvider == "auto" && os.Getenv("KUBERNETES_SERVICE_HOST") != "") - var labelProvider service.LabelProviderImpl + var labelProvider service.LabelProvider if useKubernetes { app.log.App.Debug().Msg("Using Kubernetes label provider") diff --git a/internal/controller/user_controller.go b/internal/controller/user_controller.go index f186ec0d..45a876bf 100644 --- a/internal/controller/user_controller.go +++ b/internal/controller/user_controller.go @@ -86,7 +86,7 @@ func (controller *UserController) loginHandler(c *gin.Context) { if errors.Is(err, service.ErrUserNotFound) { controller.log.App.Warn().Str("username", req.Username).Msg("User not found during login attempt") controller.auth.RecordLoginAttempt(req.Username, false) - controller.log.AuditLoginFailure(req.Username, "unkown", c.ClientIP(), "user not found") + controller.log.AuditLoginFailure(req.Username, "unknown", c.ClientIP(), "user not found") c.JSON(401, gin.H{ "status": 401, "message": "Unauthorized", diff --git a/internal/model/context.go b/internal/model/context.go index c459a620..b9e31bef 100644 --- a/internal/model/context.go +++ b/internal/model/context.go @@ -121,7 +121,7 @@ func (c *UserContext) NewFromSession(session *repository.Session) (*UserContext, Email: session.Email, }, } - // By default we assume an unkown name which is oauth + // By default we assume an unknown name which is oauth default: c.Provider = ProviderOAuth c.OAuth = &OAuthContext{ diff --git a/internal/service/access_controls_service.go b/internal/service/access_controls_service.go index f6e3cbd2..34700ea7 100644 --- a/internal/service/access_controls_service.go +++ b/internal/service/access_controls_service.go @@ -7,19 +7,19 @@ import ( "github.com/tinyauthapp/tinyauth/internal/utils/logger" ) -type LabelProviderImpl interface { +type LabelProvider interface { GetLabels(appDomain string) (*model.App, error) } type AccessControlsService struct { log *logger.Logger - labelProvider *LabelProviderImpl + labelProvider *LabelProvider static map[string]model.App } func NewAccessControlsService( log *logger.Logger, - labelProvider *LabelProviderImpl, + labelProvider *LabelProvider, static map[string]model.App) *AccessControlsService { return &AccessControlsService{ log: log, diff --git a/internal/service/auth_service.go b/internal/service/auth_service.go index ed882438..a9139bb3 100644 --- a/internal/service/auth_service.go +++ b/internal/service/auth_service.go @@ -399,12 +399,6 @@ func (auth *AuthService) DeleteSession(ctx context.Context, uuid string) (*http. auth.log.App.Error().Err(err).Str("uuid", uuid).Msg("Failed to delete session from database") } - err = auth.queries.DeleteSession(ctx, uuid) - - if err != nil { - return nil, err - } - return &http.Cookie{ Name: auth.runtime.SessionCookieName, Value: "", diff --git a/internal/utils/logger/logger.go b/internal/utils/logger/logger.go index 24d93145..b3ceda5e 100644 --- a/internal/utils/logger/logger.go +++ b/internal/utils/logger/logger.go @@ -33,7 +33,7 @@ func NewLogger() *Logger { App: model.LogStreamConfig{ Enabled: true, }, - // No reason to enabled audit by default since it will be surpressed by the log level + // No reason to enabled audit by default since it will be suppressed by the log level }, }, }