refactor: better is configured check for ldap and oidc service

internal/bootstrap/service_bootstrap.go

@@ -3,6 +3,7 @@ package bootstrap
 import (
 	"github.com/steveiliop56/tinyauth/internal/repository"
 	"github.com/steveiliop56/tinyauth/internal/service"
+	"github.com/steveiliop56/tinyauth/internal/utils/tlog"
 )
 
 type Services struct {
@@ -31,7 +32,8 @@ func (app *BootstrapApp) initServices(queries *repository.Queries) (Services, er
 	err := ldapService.Init()
 
 	if err != nil {
-		return Services{}, err
+		tlog.App.Warn().Err(err).Msg("Failed to setup LDAP service, starting without it")
+		ldapService.Unconfigure()
 	}
 
 	services.ldapService = ldapService

internal/service/ldap_service.go

@@ -24,10 +24,11 @@ type LdapServiceConfig struct {
 }
 
 type LdapService struct {
-	config LdapServiceConfig
+	config       LdapServiceConfig
-	conn   *ldapgo.Conn
+	conn         *ldapgo.Conn
-	mutex  sync.RWMutex
+	mutex        sync.RWMutex
-	cert   *tls.Certificate
+	cert         *tls.Certificate
+	isConfigured bool
 }
 
 func NewLdapService(config LdapServiceConfig) *LdapService {
@@ -36,13 +37,28 @@ func NewLdapService(config LdapServiceConfig) *LdapService {
 	}
 }
 
-// If you have an ldap address then you must need ldap
 func (ldap *LdapService) IsConfigured() bool {
-	return ldap.config.Address != ""
+	return ldap.isConfigured
+}
+
+func (ldap *LdapService) Unconfigure() error {
+	if !ldap.isConfigured {
+		return nil
+	}
+
+	if ldap.conn != nil {
+		if err := ldap.conn.Close(); err != nil {
+			return fmt.Errorf("failed to close LDAP connection: %w", err)
+		}
+	}
+
+	ldap.isConfigured = false
+	return nil
 }
 
 func (ldap *LdapService) Init() error {
-	if !ldap.IsConfigured() {
+	if ldap.config.Address == "" {
+		ldap.isConfigured = false
 		return nil
 	}
 

internal/service/oidc_service.go

@@ -83,12 +83,13 @@ type OIDCServiceConfig struct {
 }
 
 type OIDCService struct {
-	config     OIDCServiceConfig
+	config       OIDCServiceConfig
-	queries    *repository.Queries
+	queries      *repository.Queries
-	clients    map[string]config.OIDCClientConfig
+	clients      map[string]config.OIDCClientConfig
-	privateKey *rsa.PrivateKey
+	privateKey   *rsa.PrivateKey
-	publicKey  crypto.PublicKey
+	publicKey    crypto.PublicKey
-	issuer     string
+	issuer       string
+	isConfigured bool
 }
 
 func NewOIDCService(config OIDCServiceConfig, queries *repository.Queries) *OIDCService {
@@ -99,12 +100,13 @@ func NewOIDCService(config OIDCServiceConfig, queries *repository.Queries) *OIDC
 }
 
 func (service *OIDCService) IsConfigured() bool {
-	return len(service.config.Clients) > 0
+	return service.isConfigured
 }
 
 func (service *OIDCService) Init() error {
 	// If not configured, skip init
-	if !service.IsConfigured() {
+	if len(service.config.Clients) == 0 {
+		service.isConfigured = false
 		return nil
 	}