From 373ee8806ed95f7b0113877efa917c9ded589fc2 Mon Sep 17 00:00:00 2001 From: Stavros Date: Wed, 29 Apr 2026 16:04:27 +0300 Subject: [PATCH] chore: prefer errors.is instead of comparison --- internal/controller/oidc_controller.go | 2 +- internal/service/oidc_service.go | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/controller/oidc_controller.go b/internal/controller/oidc_controller.go index fa61461..8a08fd6 100644 --- a/internal/controller/oidc_controller.go +++ b/internal/controller/oidc_controller.go @@ -429,7 +429,7 @@ func (controller *OIDCController) Userinfo(c *gin.Context) { entry, err := controller.oidc.GetAccessToken(c, controller.oidc.Hash(token)) if err != nil { - if err == service.ErrTokenNotFound { + if errors.Is(err, service.ErrTokenNotFound) { tlog.App.Warn().Msg("OIDC userinfo accessed with invalid token") c.JSON(401, gin.H{ "error": "invalid_grant", diff --git a/internal/service/oidc_service.go b/internal/service/oidc_service.go index 14c6632..e4e5e6c 100644 --- a/internal/service/oidc_service.go +++ b/internal/service/oidc_service.go @@ -564,7 +564,7 @@ func (service *OIDCService) RefreshAccessToken(c *gin.Context, refreshToken stri entry, err := service.queries.GetOidcTokenByRefreshToken(c, service.Hash(refreshToken)) if err != nil { - if err == sql.ErrNoRows { + if errors.Is(err, sql.ErrNoRows) { return TokenResponse{}, ErrTokenNotFound } return TokenResponse{}, err @@ -643,7 +643,7 @@ func (service *OIDCService) GetAccessToken(c *gin.Context, tokenHash string) (re entry, err := service.queries.GetOidcToken(c, tokenHash) if err != nil { - if err == sql.ErrNoRows { + if errors.Is(err, sql.ErrNoRows) { return repository.OidcToken{}, ErrTokenNotFound } return repository.OidcToken{}, err @@ -784,7 +784,7 @@ func (service *OIDCService) Cleanup() { token, err := service.queries.GetOidcTokenBySub(ctx, expiredCode.Sub) if err != nil { - if err == sql.ErrNoRows { + if errors.Is(err, sql.ErrNoRows) { continue } tlog.App.Warn().Err(err).Msg("Failed to get OIDC token by sub")