mirror of
				https://github.com/steveiliop56/tinyauth.git
				synced 2025-10-31 06:05:43 +00:00 
			
		
		
		
	refactor: make error handling simpler
This commit is contained in:
		| @@ -15,21 +15,21 @@ type GenericUserInfoResponse struct { | ||||
|  | ||||
| func GetGenericEmail(client *http.Client, url string) (string, error) { | ||||
| 	// Using the oauth client get the user info url | ||||
| 	res, resErr := client.Get(url) | ||||
| 	res, err := client.Get(url) | ||||
|  | ||||
| 	// Check if there was an error | ||||
| 	if resErr != nil { | ||||
| 		return "", resErr | ||||
| 	if err != nil { | ||||
| 		return "", err | ||||
| 	} | ||||
|  | ||||
| 	log.Debug().Msg("Got response from generic provider") | ||||
|  | ||||
| 	// Read the body of the response | ||||
| 	body, bodyErr := io.ReadAll(res.Body) | ||||
| 	body, err := io.ReadAll(res.Body) | ||||
|  | ||||
| 	// Check if there was an error | ||||
| 	if bodyErr != nil { | ||||
| 		return "", bodyErr | ||||
| 	if err != nil { | ||||
| 		return "", err | ||||
| 	} | ||||
|  | ||||
| 	log.Debug().Msg("Read body from generic provider") | ||||
| @@ -38,11 +38,11 @@ func GetGenericEmail(client *http.Client, url string) (string, error) { | ||||
| 	var user GenericUserInfoResponse | ||||
|  | ||||
| 	// Unmarshal the body into the user struct | ||||
| 	jsonErr := json.Unmarshal(body, &user) | ||||
| 	err = json.Unmarshal(body, &user) | ||||
|  | ||||
| 	// Check if there was an error | ||||
| 	if jsonErr != nil { | ||||
| 		return "", jsonErr | ||||
| 	if err != nil { | ||||
| 		return "", err | ||||
| 	} | ||||
|  | ||||
| 	log.Debug().Msg("Parsed user from generic provider") | ||||
|   | ||||
| @@ -22,21 +22,21 @@ func GithubScopes() []string { | ||||
|  | ||||
| func GetGithubEmail(client *http.Client) (string, error) { | ||||
| 	// Get the user emails from github using the oauth http client | ||||
| 	res, resErr := client.Get("https://api.github.com/user/emails") | ||||
| 	res, err := client.Get("https://api.github.com/user/emails") | ||||
|  | ||||
| 	// Check if there was an error | ||||
| 	if resErr != nil { | ||||
| 		return "", resErr | ||||
| 	if err != nil { | ||||
| 		return "", err | ||||
| 	} | ||||
|  | ||||
| 	log.Debug().Msg("Got response from github") | ||||
|  | ||||
| 	// Read the body of the response | ||||
| 	body, bodyErr := io.ReadAll(res.Body) | ||||
| 	body, err := io.ReadAll(res.Body) | ||||
|  | ||||
| 	// Check if there was an error | ||||
| 	if bodyErr != nil { | ||||
| 		return "", bodyErr | ||||
| 	if err != nil { | ||||
| 		return "", err | ||||
| 	} | ||||
|  | ||||
| 	log.Debug().Msg("Read body from github") | ||||
| @@ -45,11 +45,11 @@ func GetGithubEmail(client *http.Client) (string, error) { | ||||
| 	var emails GithubUserInfoResponse | ||||
|  | ||||
| 	// Unmarshal the body into the user struct | ||||
| 	jsonErr := json.Unmarshal(body, &emails) | ||||
| 	err = json.Unmarshal(body, &emails) | ||||
|  | ||||
| 	// Check if there was an error | ||||
| 	if jsonErr != nil { | ||||
| 		return "", jsonErr | ||||
| 	if err != nil { | ||||
| 		return "", err | ||||
| 	} | ||||
|  | ||||
| 	log.Debug().Msg("Parsed emails from github") | ||||
|   | ||||
| @@ -20,21 +20,21 @@ func GoogleScopes() []string { | ||||
|  | ||||
| func GetGoogleEmail(client *http.Client) (string, error) { | ||||
| 	// Get the user info from google using the oauth http client | ||||
| 	res, resErr := client.Get("https://www.googleapis.com/userinfo/v2/me") | ||||
| 	res, err := client.Get("https://www.googleapis.com/userinfo/v2/me") | ||||
|  | ||||
| 	// Check if there was an error | ||||
| 	if resErr != nil { | ||||
| 		return "", resErr | ||||
| 	if err != nil { | ||||
| 		return "", err | ||||
| 	} | ||||
|  | ||||
| 	log.Debug().Msg("Got response from google") | ||||
|  | ||||
| 	// Read the body of the response | ||||
| 	body, bodyErr := io.ReadAll(res.Body) | ||||
| 	body, err := io.ReadAll(res.Body) | ||||
|  | ||||
| 	// Check if there was an error | ||||
| 	if bodyErr != nil { | ||||
| 		return "", bodyErr | ||||
| 	if err != nil { | ||||
| 		return "", err | ||||
| 	} | ||||
|  | ||||
| 	log.Debug().Msg("Read body from google") | ||||
| @@ -43,11 +43,11 @@ func GetGoogleEmail(client *http.Client) (string, error) { | ||||
| 	var user GoogleUserInfoResponse | ||||
|  | ||||
| 	// Unmarshal the body into the user struct | ||||
| 	jsonErr := json.Unmarshal(body, &user) | ||||
| 	err = json.Unmarshal(body, &user) | ||||
|  | ||||
| 	// Check if there was an error | ||||
| 	if jsonErr != nil { | ||||
| 		return "", jsonErr | ||||
| 	if err != nil { | ||||
| 		return "", err | ||||
| 	} | ||||
|  | ||||
| 	log.Debug().Msg("Parsed user from google") | ||||
|   | ||||
| @@ -128,11 +128,11 @@ func (providers *Providers) GetUser(provider string) (string, error) { | ||||
| 		log.Debug().Msg("Got client from github") | ||||
|  | ||||
| 		// Get the email from the github provider | ||||
| 		email, emailErr := GetGithubEmail(client) | ||||
| 		email, err := GetGithubEmail(client) | ||||
|  | ||||
| 		// Check if there was an error | ||||
| 		if emailErr != nil { | ||||
| 			return "", emailErr | ||||
| 		if err != nil { | ||||
| 			return "", err | ||||
| 		} | ||||
|  | ||||
| 		log.Debug().Msg("Got email from github") | ||||
| @@ -152,11 +152,11 @@ func (providers *Providers) GetUser(provider string) (string, error) { | ||||
| 		log.Debug().Msg("Got client from google") | ||||
|  | ||||
| 		// Get the email from the google provider | ||||
| 		email, emailErr := GetGoogleEmail(client) | ||||
| 		email, err := GetGoogleEmail(client) | ||||
|  | ||||
| 		// Check if there was an error | ||||
| 		if emailErr != nil { | ||||
| 			return "", emailErr | ||||
| 		if err != nil { | ||||
| 			return "", err | ||||
| 		} | ||||
|  | ||||
| 		log.Debug().Msg("Got email from google") | ||||
| @@ -176,11 +176,11 @@ func (providers *Providers) GetUser(provider string) (string, error) { | ||||
| 		log.Debug().Msg("Got client from tailscale") | ||||
|  | ||||
| 		// Get the email from the tailscale provider | ||||
| 		email, emailErr := GetTailscaleEmail(client) | ||||
| 		email, err := GetTailscaleEmail(client) | ||||
|  | ||||
| 		// Check if there was an error | ||||
| 		if emailErr != nil { | ||||
| 			return "", emailErr | ||||
| 		if err != nil { | ||||
| 			return "", err | ||||
| 		} | ||||
|  | ||||
| 		log.Debug().Msg("Got email from tailscale") | ||||
| @@ -200,11 +200,11 @@ func (providers *Providers) GetUser(provider string) (string, error) { | ||||
| 		log.Debug().Msg("Got client from generic") | ||||
|  | ||||
| 		// Get the email from the generic provider | ||||
| 		email, emailErr := GetGenericEmail(client, providers.Config.GenericUserURL) | ||||
| 		email, err := GetGenericEmail(client, providers.Config.GenericUserURL) | ||||
|  | ||||
| 		// Check if there was an error | ||||
| 		if emailErr != nil { | ||||
| 			return "", emailErr | ||||
| 		if err != nil { | ||||
| 			return "", err | ||||
| 		} | ||||
|  | ||||
| 		log.Debug().Msg("Got email from generic") | ||||
|   | ||||
| @@ -31,21 +31,21 @@ var TailscaleEndpoint = oauth2.Endpoint{ | ||||
|  | ||||
| func GetTailscaleEmail(client *http.Client) (string, error) { | ||||
| 	// Get the user info from tailscale using the oauth http client | ||||
| 	res, resErr := client.Get("https://api.tailscale.com/api/v2/tailnet/-/users") | ||||
| 	res, err := client.Get("https://api.tailscale.com/api/v2/tailnet/-/users") | ||||
|  | ||||
| 	// Check if there was an error | ||||
| 	if resErr != nil { | ||||
| 		return "", resErr | ||||
| 	if err != nil { | ||||
| 		return "", err | ||||
| 	} | ||||
|  | ||||
| 	log.Debug().Msg("Got response from tailscale") | ||||
|  | ||||
| 	// Read the body of the response | ||||
| 	body, bodyErr := io.ReadAll(res.Body) | ||||
| 	body, err := io.ReadAll(res.Body) | ||||
|  | ||||
| 	// Check if there was an error | ||||
| 	if bodyErr != nil { | ||||
| 		return "", bodyErr | ||||
| 	if err != nil { | ||||
| 		return "", err | ||||
| 	} | ||||
|  | ||||
| 	log.Debug().Msg("Read body from tailscale") | ||||
| @@ -54,11 +54,11 @@ func GetTailscaleEmail(client *http.Client) (string, error) { | ||||
| 	var users TailscaleUserInfoResponse | ||||
|  | ||||
| 	// Unmarshal the body into the user struct | ||||
| 	jsonErr := json.Unmarshal(body, &users) | ||||
| 	err = json.Unmarshal(body, &users) | ||||
|  | ||||
| 	// Check if there was an error | ||||
| 	if jsonErr != nil { | ||||
| 		return "", jsonErr | ||||
| 	if err != nil { | ||||
| 		return "", err | ||||
| 	} | ||||
|  | ||||
| 	log.Debug().Msg("Parsed users from tailscale") | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 Stavros
					Stavros