barbercollie/tinyauth
1
0
Fork 1
mirror of https://github.com/steveiliop56/tinyauth.git synced 2025-10-30 13:45:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: further coderabbit suggestions

Browse Source
This commit is contained in:
Stavros
2025-08-26 14:49:55 +03:00
parent a5e1ae096b
commit a1b6ecdd5d
9 changed files with 33 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
internal/service/auth_service.go
View File

@@ -266,6 +266,9 @@ func (auth *AuthService) DeleteSessionCookie(c *gin.Context) error {
return err
}
// Clear the cookie in the browser
c.SetCookie(auth.Config.SessionCookieName, "", -1, "/", fmt.Sprintf(".%s", auth.Config.Domain), auth.Config.SecureCookie, true)
return nil
}

8
internal/service/generic_oauth_service.go
View File

@@ -9,6 +9,7 @@ import (
"fmt"
"io"
"net/http"
"time"
"tinyauth/internal/config"
"golang.org/x/oauth2"
@@ -64,8 +65,11 @@ func (generic *GenericOAuthService) Init() error {
func (generic *GenericOAuthService) GenerateState() string {
b := make([]byte, 128)
rand.Read(b)
state := base64.URLEncoding.EncodeToString(b)
_, err := rand.Read(b)
if err != nil {
return base64.RawURLEncoding.EncodeToString(fmt.Appendf(nil, "state-%d", time.Now().UnixNano()))
}
state := base64.RawURLEncoding.EncodeToString(b)
return state
}

8
internal/service/github_oauth_service.go
View File

@@ -9,6 +9,7 @@ import (
"fmt"
"io"
"net/http"
"time"
"tinyauth/internal/config"
"golang.org/x/oauth2"
@@ -59,8 +60,11 @@ func (github *GithubOAuthService) Init() error {
func (github *GithubOAuthService) GenerateState() string {
b := make([]byte, 128)
rand.Read(b)
state := base64.URLEncoding.EncodeToString(b)
_, err := rand.Read(b)
if err != nil {
return base64.RawURLEncoding.EncodeToString(fmt.Appendf(nil, "state-%d", time.Now().UnixNano()))
}
state := base64.RawURLEncoding.EncodeToString(b)
return state
}

8
internal/service/google_oauth_service.go
View File

@@ -9,6 +9,7 @@ import (
"io"
"net/http"
"strings"
"time"
"tinyauth/internal/config"
"golang.org/x/oauth2"
@@ -54,8 +55,11 @@ func (google *GoogleOAuthService) Init() error {
func (oauth *GoogleOAuthService) GenerateState() string {
b := make([]byte, 128)
rand.Read(b)
state := base64.URLEncoding.EncodeToString(b)
_, err := rand.Read(b)
if err != nil {
return base64.RawURLEncoding.EncodeToString(fmt.Appendf(nil, "state-%d", time.Now().UnixNano()))
}
state := base64.RawURLEncoding.EncodeToString(b)
return state
}

2
internal/service/ldap_service.go
View File

@@ -140,7 +140,7 @@ func (ldap *LdapService) reconnect() error {
ldap.Conn.Close()
conn, err := ldap.connect()
if err != nil {
return nil, nil
return nil, err
}
return conn, nil
}