From b3c152fa1c4db74d4e9ad06182a4bd693c31d2fe Mon Sep 17 00:00:00 2001 From: Stavros Date: Mon, 1 Jun 2026 15:47:19 +0300 Subject: [PATCH] chore: rabbit comments --- internal/controller/oidc_controller.go | 5 ++++- internal/service/oidc_service.go | 2 +- sql/sqlite/oidc_schemas.sql | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/internal/controller/oidc_controller.go b/internal/controller/oidc_controller.go index d84bf9bf..eb916cba 100644 --- a/internal/controller/oidc_controller.go +++ b/internal/controller/oidc_controller.go @@ -332,7 +332,10 @@ func (controller *OIDCController) Token(c *gin.Context) { if ok { controller.log.App.Warn().Msg("Code reuse detected") - controller.oidc.DeleteSessionBySub(c, usedCodeSub) + err := controller.oidc.DeleteSessionBySub(c, usedCodeSub) + if err != nil { + controller.log.App.Error().Err(err).Msg("Failed to delete session for reused code") + } c.JSON(400, gin.H{ "error": "invalid_grant", }) diff --git a/internal/service/oidc_service.go b/internal/service/oidc_service.go index 235877f9..aabe8cf8 100644 --- a/internal/service/oidc_service.go +++ b/internal/service/oidc_service.go @@ -684,7 +684,7 @@ func (service *OIDCService) GetSessionByToken(ctx context.Context, tokenHash str // since there is no way for the client to access anything anymore if entry.RefreshTokenExpiresAt < time.Now().Unix() { // Deletes by sub - err := service.queries.DeleteSession(ctx, entry.Sub) + err := service.queries.DeleteOIDCSessionBySub(ctx, entry.Sub) if err != nil { return nil, err } diff --git a/sql/sqlite/oidc_schemas.sql b/sql/sqlite/oidc_schemas.sql index ce55a717..5a851033 100644 --- a/sql/sqlite/oidc_schemas.sql +++ b/sql/sqlite/oidc_schemas.sql @@ -6,6 +6,6 @@ CREATE TABLE IF NOT EXISTS "oidc_sessions" ( "client_id" TEXT NOT NULL, "token_expires_at" INTEGER NOT NULL, "refresh_token_expires_at" INTEGER NOT NULL, - "nonce" TEXT DEFAULT "", + "nonce" TEXT NOT NULL DEFAULT "", "userinfo_json" TEXT NOT NULL );