barbercollie/tinyauth
1
0
Fork 1
mirror of https://github.com/steveiliop56/tinyauth.git synced 2026-03-31 19:07:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: review comments

Browse Source
This commit is contained in:
Stavros
2026-03-29 19:38:59 +03:00
parent 15a3753622
commit b60e546ecd
6 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
internal/controller/context_controller_test.go
View File

@@ -125,7 +125,7 @@ func TestContextController(t *testing.T) {
router.ServeHTTP(recorder, request) router.ServeHTTP(recorder, request)
assert.Equal(t, recorder.Result().StatusCode, http.StatusOK) assert.Equal(t, http.StatusOK, recorder.Code)
assert.Equal(t, test.expected, recorder.Body.String()) assert.Equal(t, test.expected, recorder.Body.String())
}) })
} }

2
internal/controller/oidc_controller_test.go
View File

@@ -329,7 +329,7 @@ func TestOIDCController(t *testing.T) {
}, },
}, },
{ {
description: "Ensure token endpoint deletes code afer use", description: "Ensure token endpoint deletes code after use",
middlewares: []gin.HandlerFunc{ middlewares: []gin.HandlerFunc{
simpleCtx, simpleCtx,
}, },

4
internal/controller/proxy_controller_test.go
View File

@@ -282,7 +282,7 @@ func TestProxyController(t *testing.T) {
}, },
}, },
{ {
description: "Ensure user allow ACL allows correct user (should allow testuer)", description: "Ensure user allow ACL allows correct user (should allow testuser)",
middlewares: []gin.HandlerFunc{ middlewares: []gin.HandlerFunc{
simpleCtx, simpleCtx,
}, },
@@ -296,7 +296,7 @@ func TestProxyController(t *testing.T) {
}, },
}, },
{ {
description: "Ensure user allow ACL blocks incorrect user (should block testuer)", description: "Ensure user allow ACL blocks incorrect user (should block totpuser)",
middlewares: []gin.HandlerFunc{ middlewares: []gin.HandlerFunc{
simpleCtxTotp, simpleCtxTotp,
}, },

6
internal/controller/user_controller_test.go
View File

@@ -74,7 +74,7 @@ func TestUserController(t *testing.T) {
assert.Equal(t, "tinyauth-session", cookie.Name) assert.Equal(t, "tinyauth-session", cookie.Name)
assert.True(t, cookie.HttpOnly) assert.True(t, cookie.HttpOnly)
assert.Equal(t, "example.com", cookie.Domain) assert.Equal(t, "example.com", cookie.Domain)
assert.Equal(t, cookie.MaxAge, 10) assert.Equal(t, 10, cookie.MaxAge)
}, },
}, },
{ {
@@ -163,7 +163,7 @@ func TestUserController(t *testing.T) {
assert.Equal(t, "tinyauth-session", cookie.Name) assert.Equal(t, "tinyauth-session", cookie.Name)
assert.True(t, cookie.HttpOnly) assert.True(t, cookie.HttpOnly)
assert.Equal(t, "example.com", cookie.Domain) assert.Equal(t, "example.com", cookie.Domain)
assert.Equal(t, cookie.MaxAge, 3600) // 1 hour, default for totp pending sessions assert.Equal(t, 3600, cookie.MaxAge) // 1 hour, default for totp pending sessions
}, },
}, },
{ {
@@ -233,7 +233,7 @@ func TestUserController(t *testing.T) {
assert.Equal(t, "tinyauth-session", totpCookie.Name) assert.Equal(t, "tinyauth-session", totpCookie.Name)
assert.True(t, totpCookie.HttpOnly) assert.True(t, totpCookie.HttpOnly)
assert.Equal(t, "example.com", totpCookie.Domain) assert.Equal(t, "example.com", totpCookie.Domain)
assert.Equal(t, totpCookie.MaxAge, 10) // should use the regular session expiry time assert.Equal(t, 10, totpCookie.MaxAge) // should use the regular session expiry time
}, },
}, },
{ {

2
internal/controller/well_known_controller_test.go
View File

@@ -66,7 +66,7 @@ func TestWellKnownController(t *testing.T) {
ServiceDocumentation: "https://tinyauth.app/docs/guides/oidc", ServiceDocumentation: "https://tinyauth.app/docs/guides/oidc",
} }
assert.Equal(t, res, expected) assert.Equal(t, expected, res)
}, },
}, },
{ {