barbercollie/tinyauth
1
0
Fork 1
mirror of https://github.com/steveiliop56/tinyauth.git synced 2026-03-22 14:37:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: review comments

Browse Source
This commit is contained in:
Stavros
2026-03-21 20:52:01 +02:00
parent 4a85a9d010
commit db73c56dfe
3 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
internal/controller/oauth_controller.go
View File

@@ -73,8 +73,6 @@ func (controller *OAuthController) oauthURLHandler(c *gin.Context) {
return return
} }
tlog.App.Debug().Interface("session", session).Msg("Created new OAuth session")
authUrl, err := controller.auth.GetOAuthURL(sessionId) authUrl, err := controller.auth.GetOAuthURL(sessionId)
if err != nil { if err != nil {
@@ -145,8 +143,6 @@ func (controller *OAuthController) oauthCallbackHandler(c *gin.Context) {
c.SetCookie(controller.config.CSRFCookieName, "", -1, "/", fmt.Sprintf(".%s", controller.config.CookieDomain), controller.config.SecureCookie, true) c.SetCookie(controller.config.CSRFCookieName, "", -1, "/", fmt.Sprintf(".%s", controller.config.CookieDomain), controller.config.SecureCookie, true)
code := c.Query("code") code := c.Query("code")
tlog.App.Debug().Str("code", code).Str("state", state).Msg("Received OAuth callback")
_, err = controller.auth.GetOAuthToken(sessionIdCookie, code) _, err = controller.auth.GetOAuthToken(sessionIdCookie, code)
if err != nil { if err != nil {

3
internal/service/auth_service.go
View File

@@ -671,7 +671,6 @@ func (auth *AuthService) CleanupOAuthSessionsRoutine() {
for range ticker.C { for range ticker.C {
auth.oauthMutex.Lock() auth.oauthMutex.Lock()
defer auth.oauthMutex.Unlock()
now := time.Now() now := time.Now()
@@ -680,6 +679,8 @@ func (auth *AuthService) CleanupOAuthSessionsRoutine() {
delete(auth.oauthPendingSessions, sessionId) delete(auth.oauthPendingSessions, sessionId)
} }
} }
auth.oauthMutex.Unlock()
} }
} }

2
internal/service/oauth_service.go
View File

@@ -7,7 +7,6 @@ import (
"time" "time"
"github.com/steveiliop56/tinyauth/internal/config" "github.com/steveiliop56/tinyauth/internal/config"
"github.com/steveiliop56/tinyauth/internal/utils/tlog"
"golang.org/x/oauth2" "golang.org/x/oauth2"
) )
@@ -70,7 +69,6 @@ func (s *OAuthService) GetAuthURL(state string, verifier string) string {
} }
func (s *OAuthService) GetToken(code string, verifier string) (*oauth2.Token, error) { func (s *OAuthService) GetToken(code string, verifier string) (*oauth2.Token, error) {
tlog.App.Debug().Str("code", code).Str("verifier", verifier).Msg("Exchanging code for token")
return s.config.Exchange(s.ctx, code, oauth2.VerifierOption(verifier)) return s.config.Exchange(s.ctx, code, oauth2.VerifierOption(verifier))
} }