mirror of
https://github.com/kikootwo/ReadMeABook.git
synced 2026-06-03 04:40:09 +00:00
f23afc1ba2
Implement Plex-compatible file-extension coercion to avoid Plex silently ignoring .mp4 (and single-file .m4a) audiobooks (issue #166). Adds a DB migration and configuration key (plex_format_coercion_enabled, default true), exposes a toggle in the setup wizard and Admin Paths settings, and persists/reads the setting in the admin/setup APIs. Introduces src/lib/utils/format-coercion.ts (coerceToPlexCompatible) and related constants in src/lib/constants/audio-formats.ts (PLEX_COMPATIBLE_EXTENSIONS, COERCION_RENAME_MAP, DRM_EXTENSIONS, TRANSCODE_REQUIRED_EXTENSIONS). The organize-files processor now runs coercion after organizing/tagging and before generating the filesHash and triggering scans; coercion is idempotent, never overwrites existing targets, logs warnings on DRM/transcode/permission errors, and is non-fatal. Adds unit tests for the coercion util and updates processor & setup UI tests. Updates documentation (TABLEOFCONTENTS, file-organization, fixes/file-hash-matching, settings-pages) describing behavior, config, and constraints.
280 lines
12 KiB
Markdown
280 lines
12 KiB
Markdown
# File Organization System
|
|
|
|
**Status:** ✅ Implemented
|
|
|
|
Copies completed downloads to standardized directory structure for Plex. Automatically tags audio files with correct metadata. Originals kept for seeding, cleaned up by scheduled job after requirements met.
|
|
|
|
## Target Structure
|
|
|
|
Target directory read from database config `media_dir` (configurable in setup wizard and settings).
|
|
|
|
**Template-based organization:**
|
|
- Config key: `audiobook_path_template`
|
|
- Default: `{author}/{title} {asin}`
|
|
- Variables: `{author}`, `{title}`, `{narrator}`, `{asin}`, `{year}`
|
|
- Optional variables (narrator, asin, year) are removed if not available
|
|
|
|
**Examples:**
|
|
```
|
|
Template: {author}/{title} {asin}
|
|
Result: Douglas Adams/The Hitchhiker's Guide to the Galaxy B0009JKV9W/
|
|
|
|
Template: {author}/{title} ({year})
|
|
Result: Douglas Adams/The Hitchhiker's Guide to the Galaxy (2005)/
|
|
|
|
Template: {author}/{narrator}/{title}
|
|
Result: Douglas Adams/Stephen Fry/The Hitchhiker's Guide to the Galaxy/
|
|
```
|
|
|
|
**Legacy behavior (hardcoded):**
|
|
- With year and ASIN: `Book Title (Year) ASIN`
|
|
- With ASIN only: `Book Title ASIN`
|
|
- With year only: `Book Title (Year)`
|
|
- Fallback: `Book Title`
|
|
|
|
**Rationale:** Template system allows customization for different metadata agent configurations and user preferences while maintaining backward compatibility.
|
|
|
|
## Process
|
|
|
|
1. Download completes in `/downloads/[torrent-name]/` or `/downloads/[filename]` (single file)
|
|
1b. **Path stored** in `DownloadHistory.downloadPath` (mapped local path) for retry reliability — avoids reconstructing path from `torrentName` which may differ from actual folder name
|
|
2. Identify audiobook files (.m4b, .m4a, .mp3, .mp4, .aa, .aax, .flac, .ogg) - supports both directories and single files
|
|
3. Read media directory and path template from database config (`media_dir`, `audiobook_path_template`)
|
|
4. Apply template to create target path: `[media_dir]/[template result]/`
|
|
5. **Copy** files (not move - originals stay for seeding)
|
|
6. **Tag metadata** (if enabled) - writes correct title, author, narrator, ASIN to audio files
|
|
7. Copy cover art if found, else download from Audible
|
|
8. **Coerce file formats** (if enabled) - rename .mp4 → .m4b and single-file .m4a → .m4b for Plex compatibility (see: Plex Format Coercion below)
|
|
9. **Generate file hash** - SHA256 of sorted audio filenames for library matching (see: [fixes/file-hash-matching.md](../fixes/file-hash-matching.md))
|
|
10. Update request status to `downloaded` and store file hash in `audiobooks.files_hash`
|
|
11. **Trigger filesystem scan** (if enabled) - tells Plex/ABS to scan for new files
|
|
12. Originals remain until seeding requirements met
|
|
|
|
## Filesystem Scan Triggering
|
|
|
|
**Status:** ✅ Implemented (Both Backends)
|
|
|
|
**Purpose:** Trigger Plex/Audiobookshelf to scan filesystem after organizing files, ensuring new books appear immediately for users with disabled filesystem watchers.
|
|
|
|
**Configuration:**
|
|
- Plex: `plex.trigger_scan_after_import` (boolean, default: false)
|
|
- Audiobookshelf: `audiobookshelf.trigger_scan_after_import` (boolean, default: false)
|
|
|
|
**Flow:**
|
|
1. Files organized to media directory
|
|
2. Request status updated to `downloaded`
|
|
3. Check config setting (backend-specific)
|
|
4. If enabled: Call `ILibraryService.triggerLibraryScan(libraryId)`
|
|
5. Media server scans filesystem (async operation)
|
|
6. RMAB's scheduled check eventually detects new book
|
|
7. Request status updates to `available`
|
|
|
|
**Implementation:**
|
|
- Uses existing `ILibraryService` abstraction
|
|
- `PlexLibraryService.triggerLibraryScan()` → `POST /library/sections/{id}/refresh`
|
|
- `AudiobookshelfLibraryService.triggerLibraryScan()` → `POST /api/libraries/{id}/scan`
|
|
- Called from `organize-files.processor.ts` after status update
|
|
- Backend-agnostic using factory pattern
|
|
|
|
**Error Handling:**
|
|
- Scan failures logged but don't fail organize job
|
|
- Graceful degradation: scheduled scans eventually detect the book
|
|
- Non-blocking: async operation doesn't delay other jobs
|
|
|
|
**Use Cases:**
|
|
- Users with Plex/ABS filesystem watcher disabled
|
|
- Network-mounted media directories with delayed inotify
|
|
- Users who prefer manual control over automatic scanning
|
|
- Most users keep this disabled (default) and rely on built-in watchers
|
|
|
|
## Metadata Tagging
|
|
|
|
**Status:** ✅ Implemented
|
|
|
|
**Purpose:** Automatically writes correct metadata to audio files during file organization to improve Plex matching accuracy.
|
|
|
|
**Supported Formats:**
|
|
- m4b, m4a, mp4 (AAC audiobooks)
|
|
- mp3 (ID3v2 tags)
|
|
- flac (Vorbis comment tags)
|
|
|
|
**Metadata Written:**
|
|
- `title` - Book title
|
|
- `album` - Book title (PRIMARY field for Plex matching)
|
|
- `album_artist` - Author (PRIMARY field for Plex matching)
|
|
- `artist` - Author (fallback)
|
|
- `composer` - Narrator (standard audiobook field)
|
|
- `date` - Year
|
|
- `ASIN` - Audible ASIN (custom tag)
|
|
- M4B/M4A/MP4: `----:com.apple.iTunes:ASIN`
|
|
- MP3: Custom ID3v2 tag
|
|
|
|
**Note:** ASIN is a custom metadata tag and may not appear in standard file properties viewers (Windows/macOS/Linux). Use specialized tools to verify:
|
|
```bash
|
|
# Verify ASIN metadata with ffprobe
|
|
ffprobe -v quiet -print_format json -show_format "audiobook.m4b" | grep -i asin
|
|
|
|
# Or use exiftool
|
|
exiftool "audiobook.m4b" | grep -i asin
|
|
```
|
|
|
|
**Configuration:**
|
|
- Key: `metadata_tagging_enabled` (Configuration table)
|
|
- Default: `true`
|
|
- Configurable in: Setup wizard (Paths step), Admin settings (Paths tab)
|
|
|
|
**Implementation:**
|
|
- Uses ffmpeg with `-codec copy` (no re-encoding, metadata only)
|
|
- Fast (no audio transcoding)
|
|
- Lossless (original audio preserved)
|
|
- Runs after file copy, before cover art download
|
|
- Non-blocking (errors don't fail file organization)
|
|
- Logs success/failure per file
|
|
|
|
**Benefits:**
|
|
- Fixes torrents with missing/incorrect metadata
|
|
- Ensures Plex can match audiobooks correctly
|
|
- Writes metadata from Audible/Audnexus (known accurate)
|
|
- Prevents "[Various Albums]" and other metadata issues
|
|
- Embeds ASIN directly in audio files for better identification and matching
|
|
|
|
**Tech Stack:**
|
|
- ffmpeg (system dependency - included in Docker image)
|
|
- `src/lib/utils/metadata-tagger.ts` - Tagging utility
|
|
- Integrated into `src/lib/utils/file-organizer.ts`
|
|
|
|
**Requirements:**
|
|
- ffmpeg must be installed in the container
|
|
- **Multi-container setup** (`Dockerfile`): Added at line 56 via `apk add ffmpeg`
|
|
- **Unified setup** (`dockerfile.unified`): Added at line 16 via `apt-get install ffmpeg`
|
|
- **Verify installation:**
|
|
- Multi-container: `docker exec readmeabook ffmpeg -version`
|
|
- Unified: `docker exec readmeabook-unified ffmpeg -version`
|
|
|
|
## Plex Format Coercion
|
|
|
|
**Status:** ✅ Implemented | Issue #166
|
|
|
|
**Purpose:** Rename audiobook files to Plex-recognized extensions before the library scan. Plex silently ignores `.mp4` files in audiobook libraries; this step prevents that silent-failure mode. Rename-only — no transcoding.
|
|
|
|
**When:** After file organization and metadata tagging, before file-hash generation and before library scan trigger.
|
|
|
|
**Scope:** Audio path only. Not applied to ebook organization.
|
|
|
|
**Coercion Table:**
|
|
|
|
| Source ext | Action |
|
|
|---|---|
|
|
| `.mp4` | Rename to `.m4b` |
|
|
| `.m4a` (single audio file in folder) | Rename to `.m4b` |
|
|
| `.m4a` (multi-file folder) | No-op |
|
|
| `.m4b`, `.mp3`, `.flac`, `.aac`, `.wav`, `.alac` | No-op |
|
|
| `.aa`, `.aax` | No-op + warn ("DRM, Plex cannot import") |
|
|
| `.ogg`, `.opus`, `.wma`, other | No-op + warn ("requires transcode, not supported in v1") |
|
|
|
|
**Configuration:**
|
|
- Key: `plex_format_coercion_enabled` (Configuration table)
|
|
- Default: `true`
|
|
- Read contract: `value !== 'false'` enables (default-on semantics)
|
|
- Configurable in: Setup wizard (Paths step), Admin settings (Paths tab)
|
|
|
|
**Behavior:**
|
|
- Each audio file evaluated independently (mixed-format folders supported).
|
|
- Pre-rename collision check: if target exists → no-op + info log. Never overwrites.
|
|
- Idempotent: re-running on already-coerced folder is a no-op (extension is the signal — no marker files).
|
|
- Operates on `targetPath` (organized library files) only — never touches `/downloads` (seeding-safe).
|
|
|
|
**Failure Isolation:**
|
|
- Coercion wrapped in try/catch at processor level.
|
|
- Any failure (e.g., EPERM) logs a warning; request remains organized; original file untouched.
|
|
- A failed rename never regresses the request to "stuck."
|
|
|
|
**Tech Stack:**
|
|
- `src/lib/utils/format-coercion.ts` — coercion module
|
|
- `src/lib/constants/audio-formats.ts` — `PLEX_COMPATIBLE_EXTENSIONS`, `COERCION_RENAME_MAP`, `DRM_EXTENSIONS`, `TRANSCODE_REQUIRED_EXTENSIONS`
|
|
- Invoked from `src/lib/processors/organize-files.processor.ts` between file organization and `generateFilesHash`
|
|
- `fs.rename` (same filesystem — no cross-mount issues)
|
|
|
|
**Hash Interaction:**
|
|
- File hash (`audiobooks.files_hash`) is generated AFTER coercion → reflects post-coercion filenames.
|
|
- See: [fixes/file-hash-matching.md](../fixes/file-hash-matching.md) for hash semantics.
|
|
|
|
**Out of Scope (v1):**
|
|
- Transcoding (`.ogg`, `.opus`, `.wma`)
|
|
- DRM decoding (`.aa`, `.aax`)
|
|
- FLAC → M4B (already Plex-recognized)
|
|
- Per-request override UI
|
|
- Retroactive library sweep (new downloads only)
|
|
|
|
## Seeding Support
|
|
|
|
**Config:** `seeding_time_minutes` (0 = unlimited, never cleanup)
|
|
|
|
**Cleanup Job:** `cleanup_seeded_torrents` (every 30 mins)
|
|
1. Find requests with status 'available' or soft-deleted (orphaned downloads)
|
|
2. Query qBittorrent for actual `seeding_time` field
|
|
3. **CRITICAL: Check if torrent hash is shared by other active requests**
|
|
- If yes → Skip torrent deletion, only hard-delete the soft-deleted request record
|
|
- If no → Delete torrent + files
|
|
4. Delete torrent + files only after seeding requirement met
|
|
5. Respects config (0 = never cleanup)
|
|
|
|
**Shared Torrent Protection:**
|
|
When user deletes and re-requests the same audiobook:
|
|
- Both requests share the same torrent hash (same files)
|
|
- Cleanup finds old soft-deleted request
|
|
- Before deleting torrent, checks if any active (non-deleted) request uses same hash
|
|
- If found → Keeps torrent, only removes soft-deleted database record
|
|
- Prevents deleting source files for active requests during chapter merging
|
|
|
|
## Interface
|
|
|
|
```typescript
|
|
interface OrganizationResult {
|
|
success: boolean;
|
|
targetPath: string;
|
|
filesMovedCount: number;
|
|
errors: string[];
|
|
audioFiles: string[];
|
|
coverArtFile?: string;
|
|
}
|
|
|
|
async function organize(
|
|
downloadPath: string,
|
|
audiobook: {title: string, author: string, year?: number, coverArtUrl?: string, asin?: string}
|
|
): Promise<OrganizationResult>;
|
|
```
|
|
|
|
## Path Sanitization
|
|
|
|
- Remove invalid chars: `<>:"/\|?*`
|
|
- Trim dots/spaces
|
|
- Collapse multiple spaces
|
|
- Limit to 200 chars
|
|
- Example: `Author: The <Best>! Book?` → `Author The Best! Book`
|
|
|
|
## Configuration
|
|
|
|
- **Media directory:** Read from database config key `media_dir` (set in setup wizard or settings)
|
|
- **Path template:** Read from database config key `audiobook_path_template` (default: `{author}/{title} {asin}`)
|
|
- **Metadata tagging:** `metadata_tagging_enabled` (boolean, default: true)
|
|
- **Chapter merging:** `chapter_merging_enabled` (boolean, default: false)
|
|
- **Plex format coercion:** `plex_format_coercion_enabled` (boolean, default: true)
|
|
- **Fallback:** `/media/audiobooks` if media_dir not configured
|
|
- **Temp directory:** `/tmp/readmeabook` (or `TEMP_DIR` env var)
|
|
|
|
## Fixed Issues ✅
|
|
|
|
**1. EPERM errors** - Fixed with stream-based copy (`pipeline` + `createReadStream`/`createWriteStream`) instead of `fs.copyFile()` which uses `copy_file_range()` — a syscall that returns EPERM on cross-export NFS4 and some FUSE mounts
|
|
**2. Immediate deletion** - Changed to copy-only, scheduled cleanup after seeding
|
|
**3. Files moved not copied** - Now copies to support seeding
|
|
**4. Single file downloads** - Now supports files directly in downloads folder (not just directories)
|
|
**5. Hardcoded media path** - Now reads `media_dir` from database config instead of hardcoded `/media/audiobooks`
|
|
**6. Invalid URL error for cached cover art** - Fixed by detecting local cached thumbnails (`/api/cache/thumbnails/*`) and copying from `/app/cache/thumbnails/` instead of attempting HTTP download
|
|
|
|
## Tech Stack
|
|
|
|
- Node.js `fs/promises`
|
|
- `path` module
|
|
- axios (cover art download)
|